cython._binary_reader: cells_with_*_nodes: Generalize and simplify by directly using offset for next cell offset; close: _file_out does not exist; correct pyvista version check for version 0.32.dev0
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... before, it was used only, when `if animate`. Now, it used in any case of the call `plotter.show`.
pyvista\plotting\plotting.py:4882: On Windows OS "in the event that the user hits the exit-button on the GUI then it must be finalized and deleted as accessing it will kill the kernel... proper screenshots cannot be saved if this happens" Therefore, when you used ´_plot_point_scalars(..., screenshot=...)´, you got at ansys\mapdl\reader\rst.py:2830: ´RuntimeError: This plotter is closed and unable to save a screenshot.´ The only solution is, to pass the ´screenshot´ argument to ´plotter.show´ as done in this patch.
... the old version would break with version 1.0.0. I used the same compare operation as in <https://github.com/rbarrois/python-semanticversion/blob/master/semantic_version/base.py> tested manually.
…directly using `offset` for next cell offset - Therefore the function `cell_lookup`, which was limited to 3D cells, is no longer necessary. - Now, all cell types are supported, while the functions has even been simplified. - Now, the functions do not need the parameter `celltypes` any more. Since they are only used in rst.py in the private method `Result._extract_node_components`, I took the liberty to remove the parameter A in the respective definition und the respective call. Remark: Only tested with a pure python version of the functions, please test the cython function of the commit!
When you called `AnsysFile.close()` you got at line 255 'ansys.mapdl.reader._binary_reader.AnsysFile' object has no attribute '_file_out' as `_file_out` is never created (this line is the only occurrence).
beppo-dd
changed the title
offset for next cell offsetoffset for next cell offset; close: _file_out does not exist
… 0.32.dev0 The actual development version is 0.32.dev0: `pv._version.version_info = (0, 32, "dev0")`. There, the string `"dev0"` can not be compared with `0`, so that comparison failed for this version. To solve this, I removed the last element on the right-hand side expression of the comparison. The new comparison `(0, 32, "dev0") > (0, 32)` works now as expected. Tested manually.
beppo-dd
changed the title
offset for next cell offset; close: _file_out does not existoffset for next cell offset; close: _file_out does not exist; correct pyvista version check for version 0.32.dev0
akaszynski
approved these changes
Nov 8, 2021
|
LGTM. With |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes of cython._binary_reader
cells_with_*_nodes: Generalize and simplify by directly using
offsetfor next cell offsetcell_lookup, which was limited to 3D cells, is no longer necessary.celltypesany more. Since they are only used in rst.py in the private methodResult._extract_node_components, I took the liberty to remove the parametercelltypesin the respective definition and the respective call.offset[i+1]first andoffset[i]in the next loop step.close:
_file_outdoes not exist: When you calledAnsysFile.close()you got at line 255del self._file_out:'ansys.mapdl.reader._binary_reader.AnsysFile' object has no attribute '_file_out'as_file_outis never created (this line is the only occurrence). Thus, I removed this line in commit 1c6351e.Remark: Only tested with a pure python version of the functions, please test the cython functions of this commit!
Fix of Result._plot_point_scalars (improvement for 1c00879)
pv._version.version_info = (0, 32, "dev0"). There, the string"dev0"can not be compared with0, so that comparison failed for this version. I removed the last element on the right-hand side expression of the comparison to solve this. Now, the new comparison(0, 32, "dev0") > (0, 32)works as expected. Commit 3f6e296 was tested manually.