Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtk parse in mesh import can be switched off #87

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Conversation

NDfp
Copy link
Contributor

@NDfp NDfp commented Dec 14, 2021

added flag to (optionally) exclude the vtk parse when importing the mesh.

Background: on large model, the parsing take a considerable amount of time. If no plotting of the model is desired, the parsing is unnecessary.

@akaszynski
Copy link
Collaborator

Sorry for the late review! I've been on vacation and I'm behind on PR reviews.

@NDfp
Copy link
Contributor Author

NDfp commented Jan 5, 2022

HI Alex,
no problem.
I am a bit surprised by the error message. It seems the test failed while interpreting the mac version while building the wheel. I haven't however modified that part of the code. Could it be that the issue is in the base version and not in my modification?

@akaszynski
Copy link
Collaborator

Could it be that the issue is in the base version and not in my modification?

It's indeed an issue with the main branch.


I've made some final changes to the docstrings, but otherwise this is good to go.

Thanks for your work!

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks pass. Thanks!

Ping me for a release if you need one shortly.

@akaszynski akaszynski merged commit ec6f9f4 into ansys:main Jan 12, 2022
@NDfp
Copy link
Contributor Author

NDfp commented Jan 12, 2022

Great. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants