Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting MacOS using wheels #1217

Closed
germa89 opened this issue Jun 21, 2022 · 3 comments · Fixed by #1795
Closed

Supporting MacOS using wheels #1217

germa89 opened this issue Jun 21, 2022 · 3 comments · Fixed by #1795
Assignees
Labels
CI/CD Related with CICD, Github Actions, etc
Milestone

Comments

@germa89
Copy link
Collaborator

germa89 commented Jun 21, 2022

We should be able to build wheels for MacOS (and ideally test them).

Reference:

ansys/pymapdl-reader#141

https://cibuildwheel.readthedocs.io/en/stable/

@germa89 germa89 added NEW FEATURE CI/CD Related with CICD, Github Actions, etc labels Jun 21, 2022
@germa89 germa89 added this to the v0.63 milestone Jun 21, 2022
@RobPasMue
Copy link
Member

Linking to #1795 - Didn't know this was already in the routemap

@RobPasMue RobPasMue linked a pull request Jan 20, 2023 that will close this issue
@RobPasMue
Copy link
Member

I think that if the wheels are "smoke tested" when releasing, it's more than enough. That's at least what we do in other projects. If you want me to actually test them I can implement that 😄

@germa89
Copy link
Collaborator Author

germa89 commented Jan 24, 2023

I think that if the wheels are "smoke tested" when releasing, it's more than enough. That's at least what we do in other projects. If you want me to actually test them I can implement that 😄

I think it is fine as you did for now :).

If anything, I will do a weekly/daily testing. Will see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants