Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing savefig when vtk=false #2143

Merged
merged 7 commits into from
Jun 27, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 23, 2023

Close #2142

@germa89 germa89 self-assigned this Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #2143 (60ad07e) into main (09d55a4) will increase coverage by 0.11%.
The diff coverage is 94.40%.

@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
+ Coverage   86.43%   86.55%   +0.11%     
==========================================
  Files          45       44       -1     
  Lines        7971     7458     -513     
==========================================
- Hits         6890     6455     -435     
+ Misses       1081     1003      -78     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

Copy link
Contributor

@Gryfenfer97 Gryfenfer97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germa89 germa89 merged commit b51f3fc into main Jun 27, 2023
@germa89 germa89 deleted the feat/allowing-savefig-when-vtk=false branch June 27, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"save_fig" argument does not work with "vtk=False"
3 participants