Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding timeout to pool.__getitem__ #2176

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Adding timeout to pool.__getitem__ #2176

merged 4 commits into from
Jul 18, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 10, 2023

Close #2173

@github-actions github-actions bot added the BUG label Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #2176 (14493fa) into main (997e288) will increase coverage by 6.16%.
The diff coverage is 96.28%.

@@            Coverage Diff             @@
##             main    #2176      +/-   ##
==========================================
+ Coverage   80.82%   86.99%   +6.16%     
==========================================
  Files          44       45       +1     
  Lines        7489     8017     +528     
==========================================
+ Hits         6053     6974     +921     
+ Misses       1436     1043     -393

@germa89 germa89 requested a review from clatapie July 10, 2023 12:45
@germa89 germa89 self-assigned this Jul 10, 2023
@germa89 germa89 enabled auto-merge (squash) July 10, 2023 12:46
germa89
germa89 commented Jul 10, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@germa89 germa89 requested a review from Gryfenfer97 July 10, 2023 13:56
@germa89
Copy link
Collaborator Author

germa89 commented Jul 17, 2023

LGTM

pyansys-ci-bot
pyansys-ci-bot approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so 😬

@germa89 germa89 merged commit 76355ec into main Jul 18, 2023
@germa89 germa89 deleted the fix/test_heal branch July 18, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

@Gryfenfer97 Gryfenfer97 Awaiting requested review from Gryfenfer97

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_heal is flaky
2 participants
@germa89 @pyansys-ci-bot