Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing pyvista to 0.40.X #2198

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Fixing pyvista to 0.40.X #2198

merged 1 commit into from
Jul 21, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 21, 2023

As the title. Until dpf support pyvista 0.41

@germa89 germa89 requested a review from clatapie July 21, 2023 11:42
@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited
Loading

Codecov Report

Merging #2198 (c2dbdf9) into main (997e288) will increase coverage by 6.49%.
The diff coverage is 96.44%.

@@            Coverage Diff             @@
##             main    #2198      +/-   ##
==========================================
+ Coverage   80.82%   87.31%   +6.49%     
==========================================
  Files          44       45       +1     
  Lines        7489     8099     +610     
==========================================
+ Hits         6053     7072    +1019     
+ Misses       1436     1027     -409

@germa89
Copy link
Collaborator Author

germa89 commented Jul 21, 2023

LGTM. ;)

@germa89 germa89 enabled auto-merge (squash) July 21, 2023 11:58
pyansys-ci-bot
pyansys-ci-bot approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so 😬

@germa89 germa89 mentioned this pull request Jul 21, 2023
Merged
@germa89 germa89 merged commit 265baf8 into main Jul 21, 2023
@germa89 germa89 deleted the maint/fixing-pyvista-to-0.40.1 branch July 21, 2023 12:07
germa89 added a commit that referenced this pull request Jul 26, 2023
@germa89
Fixing pyvista to 0.40.X (#2198)
f62f486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germa89 @pyansys-ci-bot