Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying example in user-guide section #2237

Merged
merged 74 commits into from
Jan 15, 2024
Merged

Conversation

clatapie
Copy link
Contributor

Closes #2164.

@clatapie clatapie self-assigned this Aug 10, 2023
@clatapie clatapie linked an issue Aug 10, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5b4c55) 84.73% compared to head (b0cb1da) 78.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2237      +/-   ##
==========================================
- Coverage   84.73%   78.45%   -6.29%     
==========================================
  Files          47       47              
  Lines        9311     9311              
==========================================
- Hits         7890     7305     -585     
- Misses       1421     2006     +585     

@clatapie clatapie marked this pull request as ready for review January 11, 2024 08:18
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes! Overall looks good :)

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This took a while but finally is done!

Very good, you did move everything as expected. You also pick on many typos! Also fixed headers style. That is great! Thank a lot!

To improve in the following PRs, please split the PRs in smaller ones. You have done some variable substitutions (mapdl.is_local) which you could have done in another PR.
Also, because it has been a long time this PR was stale, code was duplicated (I moved somewhere, and this PR was reintroducing it). Please check for changes in files you haven't change in long time stale PRs.

Thank you a lot! 😄

doc/source/user_guide/convert.rst Outdated Show resolved Hide resolved
doc/source/user_guide/post.rst Outdated Show resolved Hide resolved
doc/source/user_guide/post.rst Outdated Show resolved Hide resolved
src/ansys/mapdl/core/examples/downloads.py Show resolved Hide resolved
src/ansys/mapdl/core/mapdl_grpc.py Outdated Show resolved Hide resolved
@clatapie clatapie merged commit 1c7fb58 into main Jan 15, 2024
28 of 29 checks passed
@clatapie clatapie deleted the doc/wrong-location-examples branch January 15, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong location of examples
3 participants