-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying example in user-guide
section
#2237
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2237 +/- ##
==========================================
- Coverage 84.73% 78.45% -6.29%
==========================================
Files 47 47
Lines 9311 9311
==========================================
- Hits 7890 7305 -585
- Misses 1421 2006 +585 |
Pyvista to PyVista
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…s/pymapdl into doc/wrong-location-examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of changes! Overall looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This took a while but finally is done!
Very good, you did move everything as expected. You also pick on many typos! Also fixed headers style. That is great! Thank a lot!
To improve in the following PRs, please split the PRs in smaller ones. You have done some variable substitutions (mapdl.is_local
) which you could have done in another PR.
Also, because it has been a long time this PR was stale, code was duplicated (I moved somewhere, and this PR was reintroducing it). Please check for changes in files you haven't change in long time stale PRs.
Thank you a lot! 😄
Closes #2164.