Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrieving non existing parameter #2238

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 10, 2023

As the title.

Close #2236

@germa89 germa89 self-assigned this Aug 10, 2023
@germa89 germa89 added the BUG label Aug 10, 2023
@germa89 germa89 requested a review from clatapie August 10, 2023 15:30
@germa89
Copy link
Collaborator Author

germa89 commented Aug 10, 2023

For your information: @EDCarman

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #2238 (3e90845) into main (e3885fb) will decrease coverage by 4.51%.
Report is 80 commits behind head on main.
The diff coverage is 89.09%.

@@            Coverage Diff             @@
##             main    #2238      +/-   ##
==========================================
- Coverage   86.39%   81.89%   -4.51%     
==========================================
  Files          45       45              
  Lines        7977     8302     +325     
==========================================
- Hits         6892     6799      -93     
- Misses       1085     1503     +418     

@germa89 germa89 enabled auto-merge (squash) August 10, 2023 15:54
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 8fac1e7 into main Aug 10, 2023
25 checks passed
@germa89 germa89 deleted the fix/parameter-does-not-exists branch August 10, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ansys.mapdl.core.parameters.Parameters raises AttributeError when accessing undefined MAPDL parameter
2 participants