-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving SATIN command #2300
Improving SATIN command #2300
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2300 +/- ##
==========================================
+ Coverage 86.39% 87.60% +1.20%
==========================================
Files 45 45
Lines 7977 8433 +456
==========================================
+ Hits 6892 7388 +496
+ Misses 1085 1045 -40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It runs correctly on my local installation as well.
There is no testing of the function though, what would you think about adding a test with a SATIN file created on-the-fly?
True. Please do add a test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improving SATIN command by implementing changes on #2285
Close #2285
Testing code:
Using this file: #2286 (reply in thread)