Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document better the arguments "replace_env_vars" and "add_env_vars" #2309

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 5, 2023

As the title

Close #2108

@germa89 germa89 self-assigned this Sep 5, 2023
@germa89 germa89 enabled auto-merge (squash) September 5, 2023 10:39
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #2309 (f4ca6a5) into main (e3885fb) will increase coverage by 1.09%.
Report is 117 commits behind head on main.
The diff coverage is 91.40%.

@@            Coverage Diff             @@
##             main    #2309      +/-   ##
==========================================
+ Coverage   86.39%   87.48%   +1.09%     
==========================================
  Files          45       45              
  Lines        7977     8433     +456     
==========================================
+ Hits         6892     7378     +486     
+ Misses       1085     1055      -30     

Copy link
Contributor

@Gryfenfer97 Gryfenfer97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germa89 germa89 merged commit 462574b into main Sep 5, 2023
25 checks passed
@germa89 germa89 deleted the doc/document-better-the-env_var-arguments branch September 5, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update_env_vars doesn't do anything for replacing environment variables
2 participants