Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update the search indexing workflow and dependency #2388

Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix: update the search indexing workflow and dependency #2388

merged 2 commits into from
Oct 6, 2023

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Oct 5, 2023 •
edited
Loading

  • update the stable indexing workflow
  • update the theme version to fix the issue with search frontend

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance labels Oct 5, 2023
germa89
germa89 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for this!

@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #2388 (02fa56b) into main (c077163) will decrease coverage by 6.04%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2388      +/-   ##
==========================================
- Coverage   87.92%   81.88%   -6.04%     
==========================================
  Files          44       44              
  Lines        8453     8453              
==========================================
- Hits         7432     6922     -510     
- Misses       1021     1531     +510

clatapie
clatapie approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 enabled auto-merge (squash) October 6, 2023 16:12
@germa89 germa89 merged commit b84acb7 into main Oct 6, 2023
25 checks passed
@germa89 germa89 deleted the docs/update-the-dependency-to-test-search branch October 6, 2023 17:05
Gryfenfer97 pushed a commit that referenced this pull request Oct 9, 2023
@Revathyvenugopal162 @germa89 @Gryfenfer97
fix: update the search indexing workflow and dependency (#2388)
02ef32c 
fix: the search indexing

Co-authored-by: German <[email protected]>
germa89 added a commit that referenced this pull request Oct 13, 2023
@germa89
Revert "fix: update the search indexing workflow and dependency (#2388)"
4f2b864 
This reverts commit 02ef32c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie clatapie approved these changes

@germa89 germa89 germa89 approved these changes

@jorgepiloto jorgepiloto Awaiting requested review from jorgepiloto

Assignees
No one assigned
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Revathyvenugopal162 @germa89 @clatapie