-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix numpy typing import #2395
fix numpy typing import #2395
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report
@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
+ Coverage 81.93% 87.88% +5.95%
==========================================
Files 44 44
Lines 8453 8453
==========================================
+ Hits 6926 7429 +503
+ Misses 1527 1024 -503 |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
@germa89 @Gryfenfer97 Not urgent - but maybe it makes sense to add a unit test that creates a venv with pymapdl but not pyvista and makes sure mapdl can still be imported. |
DTypeLike
_apply_default_theme()
even when pyvista is not installed