-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving converter #2433
Improving converter #2433
Conversation
Avoiding issue `/out,scratch`.
Improving arguments parsing
Getting ready for empty-commands.
Avoiding converting mode for the moment.
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Avoiding consider 'INF' as infinitive (float).
Add other arguments to cli Avoiding `/type` conversion Passing MAPDL arguments from launcher_mapdl to MAPDL class
…e we are connecting to already existing instances.
Adding `ADD` to skipped arguments
* Using f string for `mapdl.run` with ARGXs.
* Improving entry/exit non-interactive commands * Reducing the trailing space.
* Commenting out /exit in non_interactive
* Making sure we account for commands with empty arguments with spaces in them. * Fix error that `find_match` returns always something and it is used to create the mapdl method (which might not exist)
Fixing not finding commands in _valid_commands.
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
…hub.com/pyansys/pymapdl into feat/converter-improvements-for-ai-week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with the changes as it clearly improved the conversion of some files. If additional changes are needed in the near future, we'll create a new PR.
Thank you very much @germa89!
Close many of the issues presented in #2429
Changes:
... Many... Better check the commits which has been (more or less) explicative about the changes:
https://github.com/ansys/pymapdl/pull/2433/commits