Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving converter #2433

Merged
merged 76 commits into from
Oct 26, 2023
Merged

Improving converter #2433

merged 76 commits into from
Oct 26, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 19, 2023

Close many of the issues presented in #2429

Changes:

... Many... Better check the commits which has been (more or less) explicative about the changes:

https://github.com/ansys/pymapdl/pull/2433/commits

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

germa89 and others added 10 commits October 20, 2023 10:42
* Using f string for `mapdl.run` with ARGXs.
* Improving entry/exit non-interactive commands
* Reducing the trailing space.
* Commenting out /exit in non_interactive
* Making sure we account for commands with empty arguments with spaces in them.
* Fix error that `find_match` returns always something and it is used to create the mapdl method (which might not exist)
Fixing not finding commands in _valid_commands.
@github-actions
Copy link
Contributor

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.

This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore
you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit git commit -m "Empty comment to trigger CICD" --allow-empty.

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

@germa89 germa89 mentioned this pull request Oct 25, 2023
63 tasks
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the changes as it clearly improved the conversion of some files. If additional changes are needed in the near future, we'll create a new PR.
Thank you very much @germa89!

@germa89 germa89 merged commit f1a9895 into main Oct 26, 2023
25 checks passed
@germa89 germa89 deleted the feat/converter-improvements-for-ai-week branch October 26, 2023 16:20
@germa89 germa89 self-assigned this Oct 26, 2023
@germa89 germa89 mentioned this pull request Feb 15, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants