Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking flaky tests as xfail #2446

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Marking flaky tests as xfail #2446

merged 2 commits into from
Oct 26, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 25, 2023

They will be fixed one day.

Referenced here: #2435

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 requested a review from clatapie October 25, 2023 11:25
@germa89 germa89 self-assigned this Oct 25, 2023
@germa89 germa89 added BUG CI/CD Related with CICD, Github Actions, etc labels Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2446 (2051e35) into main (758d51b) will decrease coverage by 0.05%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2446      +/-   ##
==========================================
- Coverage   87.92%   87.87%   -0.05%     
==========================================
  Files          44       44              
  Lines        8453     8453              
==========================================
- Hits         7432     7428       -4     
- Misses       1021     1025       +4     

@germa89 germa89 enabled auto-merge (squash) October 25, 2023 11:51
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@germa89 germa89 merged commit 712ec32 into main Oct 26, 2023
25 checks passed
@germa89 germa89 deleted the fix/disabling-flaky-tests branch October 26, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants