-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing save_selection
and small change in Components API
#2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing selection bug. Adding `components.select`. Making some methods, properties.
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report
@@ Coverage Diff @@
## main #2454 +/- ##
==========================================
- Coverage 88.09% 88.08% -0.01%
==========================================
Files 44 44
Lines 8603 8613 +10
==========================================
+ Hits 7579 7587 +8
- Misses 1024 1026 +2 |
koubaa
reviewed
Oct 27, 2023
koubaa
reviewed
Oct 27, 2023
koubaa
reviewed
Oct 27, 2023
koubaa
approved these changes
Oct 27, 2023
germa89
commented
Oct 27, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
save_selection
context manager. This context manager takes care to save the current selection (ENTITIES, nodes, elements, kps, lines, areas, and volumes). The entities selection wasn't taking into account before (bug), for instance inmapdl.vplot
(See Plot command deletes component names (named selections/cm) #2452).components.select
to easier select many components.Components.list
.. it returns a tuple. Now it isComponents.names
Components.names()
andComponents.types
Close #2452