-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving Components API #2471
Merged
Merged
Improving Components API #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… return all the components from a given entity type.
Testing components
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Adding `mapdl` (lowercase) to accepts. Fixing other warnings.
Merged
Codecov Report
@@ Coverage Diff @@
## main #2471 +/- ##
==========================================
+ Coverage 83.51% 83.82% +0.31%
==========================================
Files 44 44
Lines 8660 8674 +14
==========================================
+ Hits 7232 7271 +39
+ Misses 1428 1403 -25 |
LGTM :) |
pyansys-ci-bot
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements in the Components API:
Added
_get_all_components_type
to retrieve a list of components with the same entity type. Using this in the mesh module.Close Empty element_components when cmlist is not empty #2406
Close Node components from input file #1070
Added
items
to get the component items as a tuple. Improvement.Using
save_selection
cont manager for the components selection.Document the component API. Close Document the
Components
API in the user guide #2413Adapt some examples so they reflect those changes.