Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Components API #2471

Merged
merged 24 commits into from
Nov 7, 2023
Merged

Improving Components API #2471

merged 24 commits into from
Nov 7, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 2, 2023

Several improvements in the Components API:

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 changed the title Feat/improving-components-api Improving Components API Nov 2, 2023
@germa89 germa89 self-assigned this Nov 2, 2023
@germa89 germa89 requested a review from clatapie November 2, 2023 17:55
@germa89 germa89 mentioned this pull request Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2471 (d45c14e) into main (03c9db3) will increase coverage by 0.31%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2471      +/-   ##
==========================================
+ Coverage   83.51%   83.82%   +0.31%     
==========================================
  Files          44       44              
  Lines        8660     8674      +14     
==========================================
+ Hits         7232     7271      +39     
+ Misses       1428     1403      -25     

@germa89 germa89 enabled auto-merge (squash) November 6, 2023 10:04
@germa89 germa89 disabled auto-merge November 6, 2023 12:30
@germa89 germa89 enabled auto-merge (squash) November 6, 2023 12:31
@germa89
Copy link
Collaborator Author

germa89 commented Nov 7, 2023

LGTM :)

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 1835ef3 into main Nov 7, 2023
26 checks passed
@germa89 germa89 deleted the feat/improving-components-api branch November 7, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants