Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding entry point to launch_mapdl #2533

Merged
merged 29 commits into from
Jan 8, 2024
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 24, 2023

As the title.

It allows us to do in the terminal:

Launches an MAPDL instance in the default 50052.

$ launch_mapdl

Stop the MAPDL at the default port:

$ launch_mapdl stop

I also add more options to start (like port) and stop (stop by port or PID). It also allow us to list the MAPDL instances/processes.

I need to test this locally on windows.

@germa89 germa89 requested a review from a team as a code owner November 24, 2023 12:58
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Comparison is base (0ceb0fb) 77.94% compared to head (a6852aa) 79.03%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2533      +/-   ##
==========================================
+ Coverage   77.94%   79.03%   +1.08%     
==========================================
  Files          46       47       +1     
  Lines        9118     9339     +221     
==========================================
+ Hits         7107     7381     +274     
+ Misses       2011     1958      -53     

@germa89 germa89 marked this pull request as draft November 27, 2023 10:12
@germa89
Copy link
Collaborator Author

germa89 commented Dec 21, 2023

preview:

image

@germa89
Copy link
Collaborator Author

germa89 commented Dec 21, 2023

Preview:

image

@germa89 germa89 marked this pull request as ready for review January 2, 2024 08:59
@germa89 germa89 requested a review from koubaa January 2, 2024 09:39
@germa89
Copy link
Collaborator Author

germa89 commented Jan 2, 2024

I'm not caring about coverage. Because I am not testing it in CICD yet... I need to implement a release/relock license mechanism which will come later (See #2595)

@germa89
Copy link
Collaborator Author

germa89 commented Jan 2, 2024

Pinging @clatapie for review

@germa89 germa89 enabled auto-merge (squash) January 3, 2024 16:51
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested it on my local machine and it worked fine 💯

@germa89 germa89 merged commit a167bd3 into main Jan 8, 2024
27 of 29 checks passed
@germa89 germa89 deleted the feat/adding-launch_mapdl-entrypoint branch January 8, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants