-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding entry point to launch_mapdl #2533
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2533 +/- ##
==========================================
+ Coverage 77.94% 79.03% +1.08%
==========================================
Files 46 47 +1
Lines 9118 9339 +221
==========================================
+ Hits 7107 7381 +274
+ Misses 2011 1958 -53 |
…com/pyansys/pymapdl into feat/adding-launch_mapdl-entrypoint
I'm not caring about coverage. Because I am not testing it in CICD yet... I need to implement a release/relock license mechanism which will come later (See #2595) |
Pinging @clatapie for review |
…ing on. Also making sure we do not kill ansys processes without the '-grpc' flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested it on my local machine and it worked fine 💯
As the title.
It allows us to do in the terminal:
Launches an MAPDL instance in the default 50052.
Stop the MAPDL at the default port:
I also add more options to start (like port) and stop (stop by port or PID). It also allow us to list the MAPDL instances/processes.
I need to test this locally on windows.