Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding option to _ctrl command #3002

Merged
merged 6 commits into from
Apr 18, 2024
Merged

feat: adding option to _ctrl command #3002

merged 6 commits into from
Apr 18, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 16, 2024

This is a development only command, not intended for general use

The option1 was missing in the function definition.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Apr 16, 2024
@germa89 germa89 requested a review from clatapie April 16, 2024 14:09
@germa89 germa89 marked this pull request as ready for review April 16, 2024 14:09
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.13%. Comparing base (bf3abc1) to head (41c5e77).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3002      +/-   ##
==========================================
- Coverage   86.64%   84.13%   -2.52%     
==========================================
  Files          52       52              
  Lines        9498     9498              
==========================================
- Hits         8230     7991     -239     
- Misses       1268     1507     +239     

@germa89
Copy link
Collaborator Author

germa89 commented Apr 16, 2024

Approving just to check the failing workflows are not "required".

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 enabled auto-merge (squash) April 18, 2024 09:18
@germa89 germa89 merged commit 7b3a965 into main Apr 18, 2024
24 of 27 checks passed
@germa89 germa89 deleted the fix/_ctrl-command branch April 18, 2024 09:28
@clatapie clatapie changed the title Adding option to _ctrl command feat: adding option to _ctrl command Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants