Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: making old API function discoverable when Click is not installed #3086

Merged
merged 2 commits into from
May 31, 2024
Merged

feat: making old API function discoverable when Click is not installed #3086

merged 2 commits into from
May 31, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented May 13, 2024

This function should have given an error when using if click was not installed.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this May 13, 2024
@germa89 germa89 requested a review from clatapie May 13, 2024 16:09
@github-actions github-actions bot added the BUG label May 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.19%. Comparing base (598e2e8) to head (8633e54).
Report is 35 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3086      +/-   ##
==========================================
- Coverage   86.64%   84.19%   -2.45%     
==========================================
  Files          52       52              
  Lines        9553     9553              
==========================================
- Hits         8277     8043     -234     
- Misses       1276     1510     +234

@germa89 germa89 enabled auto-merge (squash) May 31, 2024 09:08
@germa89
Copy link
Collaborator Author

germa89 commented May 31, 2024

@pyansys-ci-bot LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 89a1bac into main May 31, 2024
27 of 29 checks passed
@germa89 germa89 deleted the fix/undiscoverable-old-API-function branch May 31, 2024 09:19
@clatapie clatapie changed the title Making old API function discoverable when Click is not installed. feat: making old API function discoverable when Click is not installed. Jun 18, 2024
@clatapie clatapie changed the title feat: making old API function discoverable when Click is not installed. feat: making old API function discoverable when Click is not installed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@germa89 @codecov-commenter @PipKat @pyansys-ci-bot