Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allowing multiple IPs for remote connection on MapdlPool #3166

Merged
merged 11 commits into from
Jun 18, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 12, 2024

As the title.

It should allow to:

ips = [
    "123.45.67.01",
    "123.45.67.02",
    "123.45.67.03",
    "123.45.67.04",
    "123.45.67.05",
]

pool = MapdlPool(ip=ips)

@germa89 germa89 requested a review from a team as a code owner June 12, 2024 16:27
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.47%. Comparing base (7c1eb1e) to head (7ac1a96).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3166      +/-   ##
==========================================
- Coverage   86.63%   84.47%   -2.17%     
==========================================
  Files          52       52              
  Lines        9550     9596      +46     
==========================================
- Hits         8274     8106     -168     
- Misses       1276     1490     +214     

@germa89 germa89 requested a review from clatapie June 18, 2024 09:11
@germa89 germa89 enabled auto-merge (squash) June 18, 2024 09:11
@clatapie clatapie changed the title Allowing multiple IPs for remote connection on MapdlPool feat: allowing multiple IPs for remote connection on MapdlPool Jun 18, 2024
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit cdd3f17 into main Jun 18, 2024
37 checks passed
@germa89 germa89 deleted the feat/allowing-multiple-IPs-in-MapdlPool branch June 18, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants