ci: using trusted publisher release process #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
CI/CD
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3171 +/- ##
==========================================
- Coverage 86.63% 83.93% -2.71%
==========================================
Files 52 52
Lines 9550 9550
==========================================
- Hits 8274 8016 -258
- Misses 1276 1534 +258 |
germa89
approved these changes
Jun 17, 2024
germa89
reviewed
Jun 17, 2024
There was a problem hiding this comment.
LGTM. Thank you a lot for this @clatapie.
Can you perform a patch release after this? After all the changes you did it might be a good idea.
I wonder if we should add the other PRs made before towncrier PR to the changelog manually. What is the recommended approach?
RobPasMue
requested changes
Jun 17, 2024
RobPasMue
changed the title
|
@clatapie - be mindful of the commit name. "maint" is not allowed. |
Indeed, thank you @RobPasMue! |
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PyAnsys guidelines, this PR is to implement the ansys/actions/release-pypi-public.