Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid inspecting suspended processes #3227

Merged
merged 13 commits into from
Jul 8, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 27, 2024

Description

As the title. Retrieving info from a suspended process was crashing the system.

Issue linked

Close #3209

Checklist

@germa89 germa89 requested a review from a team as a code owner June 27, 2024 15:48
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jun 27, 2024
@germa89 germa89 added the bug Issue, problem or error in PyMAPDL label Jun 27, 2024
@germa89 germa89 enabled auto-merge (squash) June 27, 2024 15:49
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.61%. Comparing base (587a0cb) to head (8cee416).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3227      +/-   ##
==========================================
+ Coverage   82.67%   86.61%   +3.94%     
==========================================
  Files          53       53              
  Lines        9625     9630       +5     
==========================================
+ Hits         7957     8341     +384     
+ Misses       1668     1289     -379     

@github-actions github-actions bot added the CI/CD Related with CICD, Github Actions, etc label Jul 8, 2024
@github-actions github-actions bot removed the CI/CD Related with CICD, Github Actions, etc label Jul 8, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Jul 8, 2024

Latest #3251 highlighted some parts of the code that wasn't tested. These issues have propagated here too, #3247 should fix them.

@germa89
Copy link
Collaborator Author

germa89 commented Jul 8, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit d4fe3a1 into main Jul 8, 2024
49 of 59 checks passed
@germa89 germa89 deleted the fix/list-instances-when-the-process-is-suspended branch July 8, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pymapdl list fails when the process is suspended
2 participants