Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adapt static images to dark/light themes #3249

Merged
merged 11 commits into from
Jul 9, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 8, 2024

Description

Change background in some static images. I am keeping the pyvista generated background.

Issue linked

Close #3172

Checklist

@germa89 germa89 requested a review from a team as a code owner July 8, 2024 13:23
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 8, 2024 13:23
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jul 8, 2024
@github-actions github-actions bot added examples Publishing PyMAPDL examples documentation Documentation related (improving, adding, etc) labels Jul 8, 2024
@germa89 germa89 changed the title docs/adapt static images to dark/light themes docs: adapt static images to dark/light themes Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (d4fe3a1) to head (3205960).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3249      +/-   ##
==========================================
- Coverage   86.61%   84.17%   -2.45%     
==========================================
  Files          53       53              
  Lines        9630     9630              
==========================================
- Hits         8341     8106     -235     
- Misses       1289     1524     +235     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clatapie clatapie enabled auto-merge (squash) July 9, 2024 14:26
@clatapie clatapie merged commit 3bc6c7d into main Jul 9, 2024
44 checks passed
@clatapie clatapie deleted the docs/make-background-transparent-in-images branch July 9, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related (improving, adding, etc) examples Publishing PyMAPDL examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix background in documentation images
3 participants