Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/ adding apld log test #657

Merged
merged 14 commits into from
Nov 2, 2021
Merged

Feat/ adding apld log test #657

merged 14 commits into from
Nov 2, 2021

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 14, 2021 •
edited by akaszynski
Loading

Description

Fixed an issue which skipped the activation of the APDL commands recording using the keyword apdl_log in launch_mapdl.

Added also some test cases and added one for CORBA.

Tags

Fix #653
Close #653

To-Do's

  • The CORBA test function needs to be validated.
  • Linux support needs to be checked.

@akaszynski
Copy link
Collaborator

There were a few issues with this PR including:

  • ip and port need to be assigned to MAPDL grpc class
  • Any tests requiring launching MAPDL must be skipped when MAPDL isn't available.

@akaszynski akaszynski merged commit feea22d into main Nov 2, 2021
@akaszynski akaszynski deleted the feat/-adding-apld_log-test branch November 2, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAPDL Command Logging
2 participants
@germa89 @akaszynski