account for edge case with hidden nodes #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaszynski
changed the title
akaszynski
added a commit
that referenced
this pull request
Dec 4, 2021
This reverts commit 45be250.
akaszynski
added a commit
that referenced
this pull request
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #751 by adding in an additional check within
MeshGrpcto ensure that hidden nodes are not added to the internalmapdl.mesh.gridobject when pulling the nodes from the server. For reference, these hidden nodes are created for BEAM188 elements when runningSOLVE. Oddly enough, MAPDL will mention that these nodes exist inCDWRITE, but not actually write them, nor list them when runningmapdl.nlist.Bonus change
Our style check was running the spell check twice. This has been split up into two separate tasks, and the requirements are also installed in a previous step so it's easier to read the logs.