Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/post processing consistency properties #778

Merged
merged 4 commits into from
Dec 12, 2021
Merged

Feat/post processing consistency properties #778

merged 4 commits into from
Dec 12, 2021

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 10, 2021

Close #775 by implementing some API changes.

Now all the nodal and elements "getter" results methods need to be called. No @property is used for them.

@germa89 germa89 self-assigned this Dec 10, 2021
akaszynski
akaszynski approved these changes Dec 12, 2021
View reviewed changes
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in some deprecation of APIs, but to remain consistent I agree with this change.

@akaszynski akaszynski merged commit a159ae0 into main Dec 12, 2021
@akaszynski akaszynski deleted the feat/post_processing-consistency-properties branch December 12, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve consistency of mapdl.post_processing properties.
2 participants
@germa89 @akaszynski