Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MAPDL collection #809

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Fix MAPDL collection #809

merged 4 commits into from
Jan 6, 2022

Conversation

akaszynski
Copy link
Collaborator

@akaszynski akaszynski commented Jan 6, 2022

Resolve #800 by removing the additional reference to the mapdl instance in ansys/mapdl/core/logging.py.

@germa89, note that adding self.extra = extra created an additional reference to our mapdl instance, which then created a circular reference since our mapdl instance contained a reference to the logger, which contained a reference to the mapdl instance.

Once this is merged, let's plan to push a release.

@akaszynski akaszynski merged commit 9990295 into main Jan 6, 2022
@akaszynski akaszynski deleted the fix/log_collection branch January 6, 2022 18:53
@germa89
Copy link
Collaborator

germa89 commented Jan 7, 2022

So weakref is the way to go in those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAPDL Class not being collected
2 participants