Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/Boundary conditions listing wrappers #819

Merged
merged 93 commits into from
Jan 11, 2022
Merged

Feat/Boundary conditions listing wrappers #819

merged 93 commits into from
Jan 11, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 10, 2022 •
edited
Loading

As the title.

It creates BoundaryConditionsListingOutput.

TODOs

@germa89
Changed signal termination
2ef7767
@germa89
Adding CommandOutput class.
5f84f1c
@germa89
Substituting the output in mapdl_grpc for custom class.
9dc57fc
@germa89
Merge branch 'fix/os-error-when-using-os.kill-in-unit-testing' into f…
2c508bb 
…eat/richer-command-output
@germa89
Making sure all the methods call the parent class (str)
28a838f
@germa89
Testing simplied version
18525a7
@germa89
Added unit tests
9c2b52f
@germa89
Added unit tests
915444c
@germa89
Fixing the style
652ca3d
@germa89
Merge branch 'feat/richer-command-output' of https://github.com/pyans…
c8ec465 
…ys/pymapdl into feat/richer-command-output
@germa89
Fixing grammar.
9cbda1e
@germa89
Fixing grammar.
52c3e4a
@germa89
Merge branch 'feat/richer-command-output' of https://github.com/pyans…
1ff363e 
…ys/pymapdl into feat/richer-command-output
@germa89
Merge branch 'feat/richer-command-output' of https://github.com/pyans…
12b143f 
…ys/pymapdl into feat/richer-command-output
@germa89
Add test_class unit
8bc2768
@germa89
Using first implementation because the second fail because of the mod…
64dbd92 
…ified `__getattribute_`
@germa89
Changing implementation to not overwrite __class__.
c110b88
@germa89
Fixing sphinx building by rewriting __class__ method to not be overwr…
9fdc7f7 
…iten.
@germa89
Style check.
53aab29
@germa89
changing the API, cmd=command, and command= full command (cmd + args)
d98bd79
@germa89
Adding CommandOutputDataframe class.
edde78f
@germa89
Small changes.
3f17960
@germa89
Big restructure.
71665ec 
Now we detect the underlying data array based on a predefined magic word (start of data) and an empty line (end of data).
@germa89
Added check if output is modified by /verify
bcfd4b8
@germa89
Added docstrings to classes.
bdb0ae3
@germa89
Moved fixtures to main conf file
d7a15d2
@germa89
Changed class name, added supported commands.
2bbe92d 
Added support to Elist and Nlist
@germa89
Added test units.
3aece4b
@germa89
Added more unit test.
252660a
@germa89
Fixing style.
9449878
@germa89 germa89 marked this pull request as ready for review January 10, 2022 23:17
germa89 and others added 16 commits January 11, 2022 00:18
@germa89
Adding suggestions.
dd94b8b
@germa89
Fixing wrong wrapper.
ebdc5bb
@germa89
Improving test.
31cb8a6
@germa89
Merge branch 'feat/richer_cmd_output-dataframes-and-BC-list' into fea…
6359b95 
…t/dlist-command-output-wrapper
@germa89
Moving the wrapping to main Mapdl, being common to gpc, console and c…
719e463 
…orba.
@germa89
Added docstring injector.
0b9ba45
@akaszynski
Apply suggestions from code review
b3f7dda
@akaszynski
Apply suggestions from code review
5fce87a
@germa89
Replacing the check of the pandas package.
995b4cd 
Adding short doc string.
@germa89
importing pandas lazily
708cb5c
@germa89
removed trailing space.
6ad1bba
@germa89
Merge branch 'feat/richer_cmd_output-dataframes-and-BC-list' into fea…
6a969b9 
…t/dlist-command-output-wrapper
@germa89
Merge branch 'main' into feat/dlist-command-output-wrapper
aa76d63
@germa89
Added docstring injector to dlist and flist
c9fd6e6
@germa89
removing grpc wrapper
fd58da1
@germa89
Adding unit test for docstring injector.
7a45727
akaszynski
akaszynski reviewed Jan 11, 2022
View reviewed changes
tests/test_commands.py Outdated Show resolved Hide resolved
akaszynski
akaszynski approved these changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@germa89 germa89 merged commit 48f9bc8 into main Jan 11, 2022
@germa89 germa89 deleted the feat/dlist-command-output-wrapper branch January 11, 2022 17:58
This was referenced Jan 31, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germa89 @akaszynski