-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print /COM
to python console
#866
Conversation
Codecov Report
@@ Coverage Diff @@
## main #866 +/- ##
==========================================
+ Coverage 58.08% 58.16% +0.08%
==========================================
Files 172 172
Lines 10560 10576 +16
==========================================
+ Hits 6134 6152 +18
+ Misses 4426 4424 -2 |
@akaszynski coverage can be addictive (95.23%!!) |
Coverage is absolutely addictive; well done getting it past 90%. I feel that we should have another PR to just improve command coverage by reusing MAPDL regression tests. Talk to their testing team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea adding the option to print.
LGTM.
I feel it could be useful to have the
/COM
commands printing also the python console.I'm aware this might not be the greatest feature ever and it will not be used that much, but I feel it can be useful.
For example, for the
ds.dat
files which are converted from Mechanical, it is useful to print this/COM
output, so we know for example in which stage of the execution we are in, without having to add manually prints.I coded this feature to be disabled by default in Mapdl execution but it will be default in the converted (I guess MAPDL people will appreciate having this kind of input).
This feature can be activated at any moment by editing the appropriate property:
mapdl.print_com
.See unit test for an example.