Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print /COM to python console #866

Merged
merged 10 commits into from
Jan 31, 2022
Merged

Print /COM to python console #866

merged 10 commits into from
Jan 31, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 31, 2022

I feel it could be useful to have the /COM commands printing also the python console.

I'm aware this might not be the greatest feature ever and it will not be used that much, but I feel it can be useful.
For example, for the ds.dat files which are converted from Mechanical, it is useful to print this /COM output, so we know for example in which stage of the execution we are in, without having to add manually prints.

I coded this feature to be disabled by default in Mapdl execution but it will be default in the converted (I guess MAPDL people will appreciate having this kind of input).
This feature can be activated at any moment by editing the appropriate property: mapdl.print_com.
See unit test for an example.

@germa89 germa89 self-assigned this Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #866 (3b151c2) into main (05b7e60) will increase coverage by 0.08%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
+ Coverage   58.08%   58.16%   +0.08%     
==========================================
  Files         172      172              
  Lines       10560    10576      +16     
==========================================
+ Hits         6134     6152      +18     
+ Misses       4426     4424       -2     

@germa89
Copy link
Collaborator Author

germa89 commented Jan 31, 2022

@akaszynski coverage can be addictive (95.23%!!)

@akaszynski
Copy link
Collaborator

Coverage is absolutely addictive; well done getting it past 90%.

I feel that we should have another PR to just improve command coverage by reusing MAPDL regression tests. Talk to their testing team.

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea adding the option to print.

LGTM.

@akaszynski akaszynski merged commit 1859e7b into main Jan 31, 2022
@akaszynski akaszynski deleted the feat/print-coms branch January 31, 2022 22:10
@germa89 germa89 restored the feat/print-coms branch January 31, 2022 22:13
germa89 added a commit that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants