Math module file uploader #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #944 +/- ##
==========================================
- Coverage 72.79% 72.75% -0.05%
==========================================
Files 39 39
Lines 5675 5703 +28
==========================================
+ Hits 4131 4149 +18
- Misses 1544 1554 +10 |
…ly made of double float. Adding also mat_id check.
akaszynski
reviewed
Mar 9, 2022
| @@ -159,7 +159,7 @@ Next, connect to the instance of MAPDL from python with: | |||
|
|
|||
| >>> from ansys.mapdl.core import Mapdl | |||
| >>> ip = '127.0.0.1' | |||
| >>> mapdl = Mapdl(ip=ip, port=50052, request_instance=False) | |||
| >>> mapdl = Mapdl(ip=ip, port=50052, start_instance=False) | |||
There was a problem hiding this comment.
It wasn't me, it was @koubaa who told me. It seems that parameter is quite common in some private repositories I'm not in.
akaszynski
reviewed
Mar 9, 2022
akaszynski
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #930 by adding function to automatically upload files to MAPDL instance working directory.