Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary conditions plotting #963

Merged
merged 67 commits into from
May 13, 2022
Merged

Boundary conditions plotting #963

merged 67 commits into from
May 13, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 11, 2022

Implementation for plotting boundary conditions.

So far, only nodes are allowed, and only some loads/constrains are allowed.

ToDo's

  • Add documentation
  • Add unit tests

Related

@germa89 germa89 self-assigned this Mar 11, 2022
@germa89 germa89 added this to the v0.62.0 milestone Mar 11, 2022
@akaszynski
Copy link
Collaborator

Not much since this is kind of beta work

Beta is better than none.

@germa89
Copy link
Collaborator Author

germa89 commented Apr 18, 2022

I'm going to work in #731 at the same time as this (regular merges from here to there), so we can use that tech_demo as example for this feature.
I believe tech_demo 28 is more suitable that tech_demo 15. We can also add the pyvista charts.

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor doc changes, but other than that this is excellent. Nice work!

Copy link
Contributor

@koubaa koubaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks fine for an imperative plotting API (which is how the plotting API is currently designed). However, maybe in the future we should consider a declaritive plotting API, i.e. one where we create a Plot object, assign graphics entities and plot settings, and then tell it to plot. That way, you can very efficiently redraw when you change a single setting or mesh change.

@germa89
Copy link
Collaborator Author

germa89 commented Apr 19, 2022

Hi @koubaa Thank you for your comments!

I agree totally with you. This is fine for now, but if plotting gather attention, we might need to re-think the whole general_plotter function and make it more OO. I believe the way to go is subclassing Pyvista Plotter. But again, since there are many things to do, let's see this feature traction first.

@germa89 germa89 added the DO NOT MERGE Not ready to be merged yet label Apr 19, 2022
@germa89
Copy link
Collaborator Author

germa89 commented Apr 19, 2022

DO NOT MERGE

I'm preparing at the same time #731 so the changes demanded by that tech_demo will be included in this PR.

@akaszynski
Copy link
Collaborator

@germa89, let's get this merged to have the tech demos and 0.62.0 out. I'm looking forward to having this finally merged.

@germa89 germa89 merged commit f6dedc6 into main May 13, 2022
@germa89 germa89 deleted the feat/BC_Plotting branch May 13, 2022 11:19
@germa89 germa89 removed the DO NOT MERGE Not ready to be merged yet label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotting Boundary Conditions Feature/Boundary conditions plotting
3 participants