-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boundary conditions plotting #963
Conversation
Beta is better than none. |
I'm going to work in #731 at the same time as this (regular merges from here to there), so we can use that tech_demo as example for this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor doc changes, but other than that this is excellent. Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks fine for an imperative plotting API (which is how the plotting API is currently designed). However, maybe in the future we should consider a declaritive plotting API, i.e. one where we create a Plot object, assign graphics entities and plot settings, and then tell it to plot. That way, you can very efficiently redraw when you change a single setting or mesh change.
Hi @koubaa Thank you for your comments! I agree totally with you. This is fine for now, but if plotting gather attention, we might need to re-think the whole |
DO NOT MERGE I'm preparing at the same time #731 so the changes demanded by that tech_demo will be included in this PR. |
@germa89, let's get this merged to have the tech demos and 0.62.0 out. I'm looking forward to having this finally merged. |
Implementation for plotting boundary conditions.
So far, only nodes are allowed, and only some loads/constrains are allowed.
ToDo's
Related