Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PyTwin to the PyAnsys metapackage - Needs to support Python 3.7 #55

Closed
RobPasMue opened this issue Jan 11, 2023 · 9 comments
Closed
Assignees

Comments

@RobPasMue
Copy link
Member

RobPasMue commented Jan 11, 2023

Hi all!

As per @MaxJPRey request, I tried to add pytwin to the pyansys metapackage repository, so that it is distributed as part of our bundle package.

However, we encountered some issues in the process. It seems that pytwin does not support Python 3.7. This is a requirement for the metapackage since we are ensuring that all Python versions that are currently maintained keep being supported. This means Python 3.7 to 3.10. In fact, we are in process of supporting Python 3.11 as well - but this may take a while.

Would it be possible to make pytwin support Python 3.7? I can help you out implementing the needed changes. Thanks in advance!! 😃

@lboucin
Copy link
Collaborator

lboucin commented Jan 11, 2023

Hell @RobPasMue!
Thanks for looking at this.
I've created maint/python_3.7 branch to implement requested change to support python 3.7. I'll keep you posted once it is done.
FYI @chrpetre

@RobPasMue
Copy link
Member Author

That's awesome @lboucin! Thanks for looking into it. If you need any help let me know.

By the way, it looks like your pytwin-win10 runner is offline, all your workflows fail to complete because of this reason. Are you aware of this?

@lboucin
Copy link
Collaborator

lboucin commented Jan 11, 2023

Thank you @RobPasMue for pointing that out to me. I've just restarted the pytwin-win10 runner and workflows are now running fine. FYI, we've scheduled to remove this Ansys hosted runner sometime during 23R2 dev cycle.

@RobPasMue
Copy link
Member Author

Sounds like a great idea! The more we use GitHub's own runners the better - that way we do not need dedicated machines for running our CI/CD pipelines.

@lboucin
Copy link
Collaborator

lboucin commented Jan 25, 2023

Hello @RobPasMue, Fyi, I'm still working on supporting python3.7 on this branch (maint/python3.7). I've encountered multiple issues:

  • numpy support for python 3.7 (fixed by PR63)
  • importlib.metadata not a python 3.7 standard package, fixed by importing importlib_metadata instead (see here).
  • shutil.copytree does not support dirs_exist_ok argument in python 3.7 (on going, see here). I am not sure what is the best way to fix this later one. Do you have an idea?

@RobPasMue
Copy link
Member Author

Hi @lboucin!

  • Yes, indeed, PR Use flexible dependencies to numpy and pandas #63 should fix the numpy issue. It will resolve the version needed for your Python version.
  • importlb_metadata is needed for Python 3.7 indeed. You could add it to your dependencies (in your pyproject.toml file) as follows:
[tool.poetry.dependencies]
...
importlib-metadata = {version = "^4.0", python = "<3.8"}

@lboucin
Copy link
Collaborator

lboucin commented Feb 2, 2023

Hello @RobPasMue, PR66 should solve this issue. Could you please review it? Thanks!

@lboucin
Copy link
Collaborator

lboucin commented Feb 2, 2023

Completed with PR66

@lboucin lboucin closed this as completed Feb 2, 2023
@RobPasMue
Copy link
Member Author

Awesome! I recommend you do a new release with all these changes whenever possible :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants