Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flexible dependencies to numpy and pandas #63

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Use flexible dependencies to numpy and pandas #63

merged 2 commits into from
Jan 24, 2023

Conversation

lboucin
Copy link
Collaborator

@lboucin lboucin commented Jan 24, 2023

No description provided.

lboucin
lboucin commented Jan 24, 2023
View reviewed changes
Copy link
Collaborator Author

@lboucin lboucin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change self reviewed.

@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 24, 2023
@lboucin lboucin changed the title Use flexible dependencies for numpy and pandas Use flexible dependencies to numpy and pandas Jan 24, 2023
RobPasMue
RobPasMue approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. Otherwise, LGTM!

MaxJPRey
MaxJPRey approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lboucin for the quick modifications.

@lboucin lboucin merged commit 949f65d into main Jan 24, 2023
@lboucin lboucin deleted the maint/dependencies branch January 24, 2023 16:32
@RobPasMue
Copy link
Member

I think this will be key in allowing Python 3.7 @lboucin - let me know how that goes. Thanks for your support!

@lboucin lboucin mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

Assignees
No one assigned
Labels
maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lboucin @RobPasMue @MaxJPRey