Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Solve ordering issue with TBROM having more than 10 modes #114

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

chrpetre
Copy link
Collaborator

@chrpetre chrpetre commented Sep 6, 2023

  • fixing the issue on input mode coefficients mapping where there is a number of modes larger than 11 (mode coefficients ordering might be incorrect)
  • fixing the issue on output mode coefficients mapping where there is a number of modes larger than 10 (mode coefficients ordering might be incorrect)

- fixing the issue on input mode coefficients mapping where there is a number of modes larger than 11 (mode coefficients ordering might be incorrect)
- fixing the issue on output mode coefficients mapping where there is a number of modes larger than 10 (mode coefficients ordering might be incorrect)
@github-actions github-actions bot added the bug Something isn't working label Sep 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #114 (fbd3015) into main (741ce42) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   88.73%   88.82%   +0.09%     
==========================================
  Files          11       11              
  Lines        2334     2336       +2     
==========================================
+ Hits         2071     2075       +4     
+ Misses        263      261       -2     

Copy link
Collaborator

@lboucin lboucin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lboucin lboucin changed the title fixing issues when number of modes is larger FIX Solve ordering issue when TBROM have more than 10 modes for input and output fields Sep 12, 2023
@lboucin lboucin changed the title FIX Solve ordering issue when TBROM have more than 10 modes for input and output fields FIX Solve ordering issue with TBROM having more than 10 modes Sep 12, 2023
@lboucin lboucin merged commit aab47af into main Sep 12, 2023
22 checks passed
@lboucin lboucin deleted the fix/fields_mcs_ordering branch September 12, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants