Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Py3.11 again #68

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Supporting Py3.11 again #68

merged 3 commits into from
Feb 2, 2023

Conversation

RobPasMue
Copy link
Member

Closes #67

@RobPasMue RobPasMue self-assigned this Feb 2, 2023
@RobPasMue RobPasMue linked an issue Feb 2, 2023 that may be closed by this pull request
@github-actions github-actions bot added the maintenance Package and maintenance related label Feb 2, 2023
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@lboucin did you experiment any issue with Python 3.11 due to the support of Python 3.7?

@RobPasMue RobPasMue merged commit 977fff2 into main Feb 2, 2023
@RobPasMue RobPasMue deleted the maint/py311 branch February 2, 2023 13:28
@lboucin
Copy link
Collaborator

lboucin commented Feb 2, 2023

@MaxJPRey @RobPasMue I did not experiment any issue with Python 3.11. I did remove it from project.toml because we might have experienced some issue in the past with it to build the doc (if I remember well due to some issue with ansys-fluent-visualization not supporting it, if I remember well @chrpetre do you remember that?) and most of all because we were not running the unit tests with it. But it looks like it all unit tests pass with 3.11, as well as doc creation, so I'm fine with re-enabling it. Thanks for having done it!

Copy link
Collaborator

@lboucin lboucin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Python 3.11 has been removed
3 participants