Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove tests and doc dependencies from project.toml #81

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Conversation

lboucin
Copy link
Collaborator

@lboucin lboucin commented Feb 22, 2023

  • Poetry fails to create a new python 3.9.10 env based on current project.toml due to conflicting dependencies found in tests (numpy + pandas) and doc groups (ansys-fluent-core + ansys-fluent-visualization). Since these dependencies are redundant with the folder requirements that is the one actually used in the github workflows to setup tests and doc actions, I suggest we remove this redundancy.
    Impact for developers is these dependencies should now be manually added on top of the python env created with poetry, in order to run unit tests and doc build locally.
  • FIX Make SavedState id to be unique to fix occasionally failing unit test.

@github-actions github-actions bot added the maintenance Package and maintenance related label Feb 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #81 (654e44e) into main (0aa6d17) will decrease coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   87.23%   86.95%   -0.28%     
==========================================
  Files           9        9              
  Lines        1794     1794              
==========================================
- Hits         1565     1560       -5     
- Misses        229      234       +5     

@lboucin lboucin changed the title Remove tests and doc dependencies from project.toml MAINT: Remove tests and doc dependencies from project.toml Feb 22, 2023
Copy link
Collaborator

@chrpetre chrpetre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@lboucin lboucin merged commit 42dc787 into main Feb 23, 2023
@lboucin lboucin deleted the maint/dep branch February 23, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants