Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/tbrom 241 public api refactoring #96

Merged
merged 25 commits into from
Jul 2, 2023
Merged

Feat/tbrom 241 public api refactoring #96

merged 25 commits into from
Jul 2, 2023

Conversation

lboucin
Copy link
Collaborator

@lboucin lboucin commented Jun 27, 2023 •
edited
Loading

  • Refactor public methods signature
  • Remove useless public methods or methods
  • Reorganize test_tbrom module
  • Update example 06
  • Refactor the way error string are maintained
  • Remove any usage of pytest.raises(...) in unit tests (since it was causing some dark issues in the unit test)

@github-actions github-actions bot added the enhancement New features or code improvements label Jun 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023 •
edited
Loading

Codecov Report

Merging #96 (ae8ad28) into main (2538282) will increase coverage by 0.53%.
The diff coverage is 95.20%.

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   88.04%   88.57%   +0.53%     
==========================================
  Files          11       11              
  Lines        2209     2224      +15     
==========================================
+ Hits         1945     1970      +25     
+ Misses        264      254      -10

@lboucin lboucin requested a review from chrpetre June 27, 2023 21:39
Lucas Boucinha and others added 17 commits June 28, 2023 15:32
Fix issue with test_each_twin_model_has_a_subfolder_in_wd
313bbf8
Remove TwinModel.tbroms as public property
6923c46
Add debug print
fc7238b
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e88e6a9 
for more information, see https://pre-commit.ci
Simplify tbrom_init logic
f8d0822
Add more debug info
c944fbe
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8fcacf3 
for more information, see https://pre-commit.ci
Fix TbRom unit test issue due to field inputs order is OS dependant
6dced6e
Merge with remote
2bc6331
Fix TbRom unit test issue related to field input names order that dep…
4e06426 
…ends on OS
Rework TbRom instantiation and initialization logic
8d9c35b
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4416ee7 
for more information, see https://pre-commit.ci
Refactor error message handling in TbRom and update unittests
b59a0fb
Fix merge with remote branch
461f4c9
Fix unit test issue with field name order
f9cb5d9
Code cleaning
70244b7
Remove usage of pytest.raises() in unit tests
ae8ad28
@github-actions github-actions bot added the testing Anything related to tests label Jun 30, 2023
@lboucin
Copy link
Collaborator Author

lboucin commented Jun 30, 2023 •
edited
Loading

@chrpetre This one is ready to be merged and contains a lot of refactoring. I suggest we merge it and create a new one to incorporate your last dev from the PR95. What do you think?

chrpetre
chrpetre approved these changes Jul 2, 2023
View reviewed changes
Copy link
Collaborator

@chrpetre chrpetre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, let's merge it and continue on a new one with the latest development

@chrpetre chrpetre merged commit 4d64de4 into main Jul 2, 2023
21 checks passed
@chrpetre chrpetre deleted the feat/tbrom_241_public_api_refactoring branch July 2, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrpetre chrpetre chrpetre approved these changes

Assignees
No one assigned
Labels
enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lboucin @codecov-commenter @chrpetre