Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field inputs and outputs to batch evaluation #97

Merged
merged 9 commits into from
Jul 4, 2023
Merged

Add field inputs and outputs to batch evaluation #97

merged 9 commits into from
Jul 4, 2023

Conversation

lboucin
Copy link
Collaborator

@lboucin lboucin commented Jul 4, 2023 •
edited
Loading

  • Add field_inputs argument to TwinModel.evaluation_batch(...)
  • Add generate_snapshot_batch(...) method to TwinModel
  • Update example 06
  • Add unit tests

@lboucin lboucin requested a review from chrpetre July 4, 2023 07:27
@lboucin
Copy link
Collaborator Author

lboucin commented Jul 4, 2023

@chrpetre Please make a first round of review of public API signature and example 06 update, after what I'll new unit tests. Thanks

@github-actions github-actions bot added the enhancement New features or code improvements label Jul 4, 2023
chrpetre
chrpetre approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@chrpetre chrpetre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks good to me thanks @lboucin

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #97 (2d5f4fa) into main (4d64de4) will increase coverage by 0.04%.
The diff coverage is 91.91%.

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   88.57%   88.62%   +0.04%     
==========================================
  Files          11       11              
  Lines        2224     2294      +70     
==========================================
+ Hits         1970     2033      +63     
- Misses        254      261       +7

@lboucin
Copy link
Collaborator Author

lboucin commented Jul 4, 2023

All good. Merging!

@lboucin lboucin merged commit d8a1a7c into main Jul 4, 2023
@lboucin lboucin deleted the feat/tbrom_241_batch_eval branch July 4, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrpetre chrpetre chrpetre approved these changes

Assignees
No one assigned
Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lboucin @codecov-commenter @chrpetre