Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modal support hooks #20949

Merged
merged 13 commits into from
Feb 3, 2020
Merged

feat: Modal support hooks #20949

merged 13 commits into from
Feb 3, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 16, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #20177

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Modal add useModal hook to support context access.
🇨🇳 Chinese Modal 添加 useModal hook 以支持 context 访问。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
  • Test case

View rendered components/modal/demo/hooks.md

@zombieJ zombieJ changed the title feat: Modal support hooks [WIP] feat: Modal support hooks Jan 16, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 16, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5b30bb3:

Sandbox Source
antd reproduction template Configuration

@zombieJ zombieJ changed the title [WIP] feat: Modal support hooks feat: Modal support hooks Jan 16, 2020
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (feature@5e341af). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             feature   #20949   +/-   ##
==========================================
  Coverage           ?   97.48%           
==========================================
  Files              ?      300           
  Lines              ?     6957           
  Branches           ?     1923           
==========================================
  Hits               ?     6782           
  Misses             ?      175           
  Partials           ?        0
Impacted Files Coverage Δ
components/drawer/index.tsx 98.78% <ø> (ø)
components/auto-complete/index.tsx 95% <ø> (ø)
components/tree/Tree.tsx 100% <ø> (ø)
components/progress/Line.tsx 96.66% <ø> (ø)
components/table/Table.tsx 96.66% <100%> (ø)
components/statistic/Countdown.tsx 100% <100%> (ø)
components/transfer/list.tsx 100% <100%> (ø)
components/form/FormItem.tsx 98.96% <100%> (ø)
components/table/hooks/useSelection.tsx 98.83% <100%> (ø)
components/dropdown/dropdown-button.tsx 100% <100%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e341af...5b30bb3. Read the comment docs.

@zombieJ
Copy link
Member Author

zombieJ commented Jan 16, 2020

Please help to review.

@zombieJ
Copy link
Member Author

zombieJ commented Jan 20, 2020

ping

---
order: 12
title:
zh-CN: 使用 hooks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里最好写成解决 context 问题的标题。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用 hooks 不是关键词。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants