Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Nest FormItem warning #21896

Merged
merged 1 commit into from
Mar 5, 2020
Merged

fix: Nest FormItem warning #21896

merged 1 commit into from
Mar 5, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 5, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21889

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix nest Form.Item dynamic remove will warning in React.
🇨🇳 Chinese 修复嵌套 Form.Item 移除会导致 React 报警告的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@zombieJ
Copy link
Member Author

zombieJ commented Mar 5, 2020

test 环境下怎么都不会 warning，所以没有加 test case。

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 5, 2020 •
edited
Loading

@zombieJ zombieJ merged commit 103385e into master Mar 5, 2020
@zombieJ zombieJ deleted the fix-form-warn branch March 5, 2020 08:22
@afc163 afc163 mentioned this pull request Mar 8, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 10, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 25, 2020
Closed
@dibaosong
Copy link

4.0.4版本，Form.Item嵌套使用，在路由跳转时，React会报警告

@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unmounting Nested Form.Items causes a React error
3 participants
@zombieJ @ant-design-bot @dibaosong