Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ⬆️ BackTop not working in iframe #22788

Merged
merged 8 commits into from
Apr 1, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 31, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • 在 iframe 里不生效的问题。
  • 优化了 BackTop 的演示文档。
  • 提升了滚动性能。

📝 Changelog

Language Changelog
🇺🇸 English Fix BackTop not working in iframe and improve it's perfermance.
🇨🇳 Chinese 修复 BackTop 在 iframe 里不生效并提升了组件性能。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/back-top/demo/basic.md
View rendered components/back-top/demo/custom.md

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@afc163 afc163 changed the title fix: BackTop not working in iframe [WIP] fix: BackTop not working in iframe Mar 31, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 31, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5c7d707:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 31, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ed3bf43:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 changed the title [WIP] fix: BackTop not working in iframe fix: BackTop not working in iframe Mar 31, 2020
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #22788 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22788      +/-   ##
==========================================
+ Coverage   98.28%   98.31%   +0.03%     
==========================================
  Files         361      361              
  Lines        7211     7235      +24     
  Branches     1933     1985      +52     
==========================================
+ Hits         7087     7113      +26     
+ Misses        124      122       -2
Impacted Files Coverage Δ
components/_util/getScroll.tsx 100% <100%> (+20%) ⬆️
components/_util/scrollTo.ts 100% <100%> (ø) ⬆️
components/back-top/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef3215...ed3bf43. Read the comment docs.

@afc163
Copy link
Member Author

afc163 commented Mar 31, 2020

我补一下覆盖率。

@afc163 afc163 changed the title fix: BackTop not working in iframe fix: ⬆️ BackTop not working in iframe Apr 1, 2020
@afc163 afc163 merged commit aca2656 into master Apr 1, 2020
@afc163 afc163 deleted the fix-back-top-in-iframe branch April 1, 2020 09:38
@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants