refactor: Replace BackTop with rc-motion #27840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 65b1c2f:
|
Codecov Report
@@ Coverage Diff @@
## master #27840 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 389 389
Lines 7374 7373 -1
Branches 2043 2042 -1
=========================================
- Hits 7374 7373 -1
Continue to review full report at Codecov.
|
|
Size Change: +76 B (0%) Total Size: 789 kB
ℹ️ View Unchanged
|
afc163
reviewed
Nov 18, 2020
| {({ className: motionClassName }) => { | ||
| const childNode = children || defaultElement; | ||
| return ( | ||
| <div> |
There was a problem hiding this comment.
原本的 rc-animate 配置了 component="div"，这边迁移先做保留。
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
rc-motioninstead ofrc-animate.rc-animate代替rc-motion。☑️ Self Check before Merge