Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter without close dropdown (#28652) #28688

Merged
merged 3 commits into from
Jan 5, 2021
Merged

feat: filter without close dropdown (#28652) #28688

merged 3 commits into from
Jan 5, 2021

Conversation

alekye
Copy link
Contributor

@alekye alekye commented Jan 5, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

[#28652]

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Execute Table custom filter without close drop down menu.
🇨🇳 Chinese Table 组件自定义筛选器,执行筛选时不关闭筛选菜单。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/table/demo/custom-filter-panel.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jan 5, 2021

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e6586d8:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2021

Size Change: +45 B (0%)

Total Size: 796 kB

Filename Size Change
./dist/antd-with-locales.min.js 316 kB +23 B (0%)
./dist/antd.min.js 278 kB +22 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.9 kB 0 B
./dist/antd.dark.min.css 68.1 kB 0 B
./dist/antd.min.css 66.9 kB 0 B

compressed-size-action

type="link"
size="small"
onClick={() => {
confirm(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
confirm(false);
confirm({ closeDropdown: false });

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@afc163 afc163 merged commit 168db12 into ant-design:feature Jan 5, 2021
size="small"
onClick={() => {
confirm({ closeDropdown: false });
console.log('1234');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个忘记删了。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要再提交一次吗

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

发新PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

发了

@alekye
Copy link
Contributor Author

alekye commented Jan 11, 2021

@afc163 ,请问这个PR怎么没有merge到master

@yoyo837
Copy link
Contributor

yoyo837 commented Jan 11, 2021

@afc163 ,请问这个PR怎么没有merge到master

我本想看一下为什么,但是奈何github同步不下来 😂,好慢

@alekye alekye mentioned this pull request Jan 11, 2021
19 tasks
@yoyo837
Copy link
Contributor

yoyo837 commented Jan 11, 2021

4.10.0的minor版本是7天前,你这个是6天前,得等下个minor了,也就是月底的4.11.0.

@alekye
Copy link
Contributor Author

alekye commented Jan 11, 2021

好的,明白了,谢谢

collinbarrett added a commit to collinbarrett/FilterLists that referenced this pull request Jan 26, 2021
collinbarrett added a commit to collinbarrett/FilterLists that referenced this pull request Jan 26, 2021
collinbarrett added a commit to collinbarrett/FilterLists that referenced this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants