Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add urdu language intl #31346

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Conversation

MuhammadAnas190
Copy link
Contributor

@MuhammadAnas190 MuhammadAnas190 commented Jul 11, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Added Urdu language (ur_PK) locale
🇨🇳 Chinese 添加了乌尔都语 (ur_PK) 语言环境

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2021

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #31346 (75695d4) into feature (f45f735) will increase coverage by 1.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #31346      +/-   ##
===========================================
+ Coverage    98.81%   99.96%   +1.14%     
===========================================
  Files          363      403      +40     
  Lines         7280     7580     +300     
  Branches      1967     2138     +171     
===========================================
+ Hits          7194     7577     +383     
+ Misses          86        3      -83     
Impacted Files Coverage Δ
components/_util/easings.ts 100.00% <ø> (ø)
components/_util/raf.ts 100.00% <ø> (ø)
components/_util/scrollTo.ts 100.00% <ø> (ø)
components/_util/type.ts 100.00% <ø> (ø)
components/calendar/generateCalendar.tsx 100.00% <ø> (+1.33%) ⬆️
components/calendar/index.tsx 100.00% <ø> (ø)
components/card/Grid.tsx 100.00% <ø> (ø)
components/_util/ActionButton.tsx 100.00% <100.00%> (ø)
components/_util/getScroll.tsx 100.00% <100.00%> (ø)
components/_util/hooks/useFlexGapSupport.ts 100.00% <100.00%> (ø)
... and 250 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 442ef88...75695d4. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Jul 12, 2021

#31346 (comment)

@afc163
Copy link
Member

afc163 commented Jul 12, 2021

  1. Please run npm test -- components/locale-provider/__tests__/index.test.js and commit the snapshot change.
  2. Please add changelog in PR content.

@MuhammadAnas190
Copy link
Contributor Author

MuhammadAnas190 commented Jul 12, 2021

@afc163 updated the PR content and snapshot. Please check
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants