fix: Typography ellipsis not working in Table #32447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #32447 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 414 414
Lines 7586 7589 +3
Branches 2132 2132
=========================================
+ Hits 7586 7589 +3
Continue to review full report at Codecov.
|
|
Size Change: +16 B (0%) Total Size: 920 kB
ℹ️ View Unchanged
|
19 tasks
hydraZty
reviewed
Oct 19, 2021
| Math.floor(lineHeight) * (rows + 1) + | ||
| const overflowRows = rows + 1; | ||
| const oneRowMaxHeight = | ||
| Math.floor(lineHeight) + | ||
| pxToNumber(originStyle.paddingTop) + |
There was a problem hiding this comment.
oneRowMaxHeight 应当不包括 padding
const oneRowMaxHeight = Math.floor(lineHeight)
| @@ -128,7 +129,9 @@ export default ( | |||
|
|
|||
| // Check if ellipsis in measure div is height enough for content | |||
| function inRange() { | |||
| return Math.ceil(ellipsisContainer.getBoundingClientRect().height) < maxHeight; | |||
| return ( | |||
| Math.ceil(ellipsisContainer.getBoundingClientRect().height / overflowRows) < oneRowMaxHeight | |||
There was a problem hiding this comment.
pureHeight = ellipsisContainer.getBoundingClientRect().height -
pxToNumber(originStyle.paddingBottom) -
pxToNumber(originStyle.paddingBottom) -
pxToNumber(originStyle.borderTop) -
pxToNumber(originStyle.borderBottom)
Math.ceil(pureHeight / overflowRows) < oneRowMaxHeight
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #32432
💡 Background and solution
📝 Changelog
ellipsiscalculation bug when browser zoomed in.ellipsis在 Chrome 下屏幕缩小时溢出的问题。☑️ Self Check before Merge