Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add value parameter to textarea showCount.formatter #36793

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

JarvisArt
Copy link
Contributor

@JarvisArt JarvisArt commented Jul 29, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #36773

💡 Background and solution

1.This PR only supports TextArea. (这个 pr 只支持了TextArea组件)
2.Input needs to be modified rc-input Project, to be submitted pr. (Input组件需要修改 rc-input 仓库,待提交pr)

📝 Changelog

Language Changelog
🇺🇸 English Input.TextArea add value parameter to showCount.formatter.
🇨🇳 Chinese Input.TextArea 组件 showCount.formatterAPI 添加value` 参数

☑️ Self-Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2022

@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #36793 (9d3019d) into feature (aa648d2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           feature    #36793   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          437       437           
  Lines         8038      8038           
  Branches      2421      2421           
=========================================
  Hits          8038      8038           
Impacted Files Coverage Δ
components/input/TextArea.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa648d2...9d3019d. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Aug 1, 2022

@JarvisArt
Copy link
Contributor Author

https://github.com/react-component/input/releases/tag/v0.1.2

rc-input 需要升起来。

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants