Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change slide tooltip api #37043

Merged
merged 8 commits into from
Aug 18, 2022

Conversation

yykoypj
Copy link
Contributor

@yykoypj yykoypj commented Aug 13, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#36609

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English put tooltip relate props into an object for Slider
🇨🇳 Chinese 将Slider的tooltip相关属性放到一个对象中

☑️ Self-Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2022

@yykoypj yykoypj mentioned this pull request Aug 13, 2022
21 tasks
@yykoypj yykoypj changed the title [WIP]feat: change slide tooltip api feat: change slide tooltip api Aug 14, 2022
@yykoypj
Copy link
Contributor Author

yykoypj commented Aug 14, 2022

ci没通过应该是rc-image的版本升级的问题吧~

@afc163
Copy link
Member

afc163 commented Aug 16, 2022

rebase master

@yykoypj yykoypj force-pushed the feat/change-slide-tooltip-api branch from 1369ba1 to a49babc Compare August 16, 2022 02:22
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #37043 (81aebc4) into next (25e001f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              next    #37043   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          517       517           
  Lines         8804      8803    -1     
  Branches      2456      2454    -2     
=========================================
- Hits          8804      8803    -1     
Impacted Files Coverage Δ
components/slider/index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zombieJ zombieJ merged commit 42bbd9e into ant-design:next Aug 18, 2022
@MadCcc MadCcc mentioned this pull request Nov 17, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants