Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch visible to open for Dropdown #37232

Merged

Conversation

yykoypj
Copy link
Contributor

@yykoypj yykoypj commented Aug 25, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Enhancement feature
  • Internationalization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#36609

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English replace visible to open for Dropdown
🇨🇳 Chinese Dropdown的visible改为open

☑️ Self-Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022

@yykoypj yykoypj mentioned this pull request Aug 25, 2022
21 tasks
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #37232 (0fee5bf) into feature (6b658da) will decrease coverage by 0.01%.
The diff coverage is 93.75%.

❗ Current head 0fee5bf differs from pull request most recent head 055e5ad. Consider uploading reports for the commit 055e5ad to get more accurate results

@@             Coverage Diff             @@
##           feature   #37232      +/-   ##
===========================================
- Coverage   100.00%   99.98%   -0.02%     
===========================================
  Files          441      441              
  Lines         8172     8181       +9     
  Branches      2474     2478       +4     
===========================================
+ Hits          8172     8180       +8     
- Misses           0        1       +1     
Impacted Files Coverage Δ
...omponents/table/hooks/useFilter/FilterDropdown.tsx 100.00% <ø> (ø)
components/dropdown/dropdown-button.tsx 96.00% <80.00%> (-4.00%) ⬇️
components/dropdown/dropdown.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yykoypj yykoypj force-pushed the feat/visible-to-open-for-Dropdown branch from 5d57ac6 to 0fee5bf Compare August 29, 2022 09:13
@MadCcc MadCcc merged commit bcb0b4d into ant-design:feature Sep 2, 2022
This was referenced Sep 4, 2022
linaaaqi pushed a commit to linaaaqi/ant-design that referenced this pull request Sep 5, 2022
* feat: switch visible to open for Dropdown

* fix: merge state

* fix: props pass

* test: fix coverage
@MadCcc MadCcc mentioned this pull request Sep 5, 2022
19 tasks
@atanasov-deyan
Copy link

given this is an API breaking change, shouldn't all related PRs that switch visibility state prop from visible to open be done in a new major release?

Related PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants