Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): Button block prop not working #38869

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix(button): Button block prop not working #38869

merged 1 commit into from
Nov 22, 2022

Conversation

jjlstruggle
Copy link
Contributor

@jjlstruggle jjlstruggle commented Nov 22, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #38866

💡 Background and solution

📝 Changelog

将block的样式提取出来放在shape样式后面生成

Language Changelog
🇺🇸 English Fix Button block prop is not working when shape="round".
🇨🇳 Chinese 修复 Button block 属性有时不生效的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

@jjlstruggle jjlstruggle changed the title fix-blockBtnWithShape fix(button): blockBtnWithShape Nov 22, 2022
@afc163 afc163 changed the title fix(button): blockBtnWithShape fix(button): Button block prop not working Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e3fc9e8) compared to base (e93f660).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38869   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          544       544           
  Lines         9357      9357           
  Branches      2651      2651           
=========================================
  Hits          9357      9357           
Impacted Files Coverage Δ
components/dropdown/dropdown-button.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit c4c2ee7 into ant-design:master Nov 22, 2022
This was referenced Nov 25, 2022
@jjlstruggle jjlstruggle deleted the fix-blockBtnWithShape branch August 24, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

给button添加block和shape=round的props后 block样式会被覆盖导致失效
2 participants