Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Upload loading icon should be primary color #39114

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

MARKX97
Copy link
Contributor

@MARKX97 MARKX97 commented Nov 30, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

close #39112

📝 Changelog

Language Changelog
🇺🇸 English Change Upload primary color
🇨🇳 Chinese 增加upload默认颜色

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2022

@@ -33,6 +33,7 @@ const genPictureStyle: GenerateStyle<UploadToken> = (token) => {

[iconCls]: {
fontSize: token.fontSizeHeading2,
color: token.blue,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
color: token.blue,
color: token.colorPrimary,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -79,6 +80,8 @@ const genPictureStyle: GenerateStyle<UploadToken> = (token) => {

const genPictureCardStyle: GenerateStyle<UploadToken> = (token) => {
const { componentCls, iconCls, fontSizeLG, colorTextLightSolid } = token;
console.log('token', token);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not add this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (eea1f30) compared to base (479e4e8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39114   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          546       546           
  Lines         9361      9361           
  Branches      2652      2652           
=========================================
  Hits          9361      9361           
Impacted Files Coverage Δ
components/upload/style/picture.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 changed the title Fix:Upload loading icon should be primary color style: Upload loading icon should be primary color Nov 30, 2022
@afc163 afc163 merged commit a364e58 into ant-design:master Nov 30, 2022
@MadCcc MadCcc mentioned this pull request Nov 30, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload loading icon should be primary color
2 participants